Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing 'Project Name' from (x) clear button; still display the "Create Project" button activated #238

Closed
sdgun opened this issue Sep 28, 2016 · 6 comments
Assignees

Comments

@sdgun
Copy link

sdgun commented Sep 28, 2016

Description

Clearing 'Project Name' from (x) clear button; still display the "Create Project" button activated

Steps to Reproduce

  • Open the sites
  • Login as a valid user (pat_monahan)
  • In the Projects
  • Click '+ New Projects"
  • Enter all the required data
  • Clear the 'Project Name' from (x) clear button
  • Check the "Create Project" button

Expected Result(s)

  • Must disable the "Create Project" button

Actual Result

  • Clearing 'Project Name' from (x) clear button; still display the "Create Project" button activated

Environment

  • Device(s): Laptop
  • Browser(s): IE11
  • Operating System: Windows 7 Pro 64bit
  • User Accounts: pat_monahan

Image/Video/JS Log (If not attached here, Please check the comment section)

@sdgun
Copy link
Author

sdgun commented Sep 28, 2016

@mahestro
Copy link
Contributor

mahestro commented Oct 3, 2016

Valid.

@fnisen
Copy link
Contributor

fnisen commented Oct 26, 2016

Similar to #241, but not exactly the same.

@vikasrohit
Copy link

Its issue with React v15.x, facebook/react#6822 There is a workaround to overcome the issue, however, that would make the form slow because it requires handling onInput event instead of onChange event and onInput event is fired as soon as the value is changed in the text box. If the issue is critical, we can apply the workaround only for IE by detecting the browser.

cc: @fnisen @vic-appirio @parthshah

@fnisen
Copy link
Contributor

fnisen commented Nov 4, 2016

@vikasrohit how about turning off the "X" in IE, as one of the other commenters suggested?

@vikasrohit
Copy link

Done. Removed the "X" for IE.

vikasrohit pushed a commit that referenced this issue Nov 7, 2016
… still display the "Create Project" button activated

-- Removed the X button for IE
vikasrohit pushed a commit that referenced this issue Nov 7, 2016
…on-ie11

Github issue #238 #241 Clearing 'Project Name' from (x) clear button;…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants