[FEE-927] add offset on Tooltip popover content #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae93176 to
a864b3f
Compare
|
Released prerelease version |
|
Jira Issue: https://appfolio.atlassian.net/browse/FEE-927 |
Brian-Holland
commented
Feb 3, 2025
Comment on lines
+22
to
+27
| const offsets: Record<string, [number, number]> = { | ||
| top: [0, 5], | ||
| bottom: [0, 5], | ||
| left: [0, 8], | ||
| right: [0, 8], | ||
| }; |
There was a problem hiding this comment.
Offsets are uneven here to account for the vertical space around text that isn't there horizontally.
JeremyRH
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current Tooltip implementation does not have much, if any, space between the tooltip arrow and the content it's pointing to. This fix adds an offset based on the placement direction.
Before:
After:
