Don't capture non-left mouse clicks on combobox #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0780af to
cbaca10
Compare
b98a79e to
1efc60b
Compare
1efc60b to
cddfcd2
Compare
adinajohnson
approved these changes
Jan 24, 2024
Right-clicking on a combobox input or menu option should not behave like a left click. this commit skips the custom mouse down handling if not left-click.
cddfcd2 to
319627a
Compare
|
Released prerelease version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APT-1372
Right-clicking on a combobox input or menu option should not behave like a left click. this commit skips the custom mouse down handling if not left-click. Impetus for this change is the use of combobox within our bulk-uploader component. The cells of the table each have a custom right-click menu, but when a user right clicks on a cell that contains a combobox, both the right-click menu and the combobox dropdown appear, which is not desired (see video below)
Before:
combobox.capturing.right.click.mov
After:
combobox.not.capturing.right.click.mov
Reason for change:
reason.for.combox.change.mov