Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

*: appc v0.8.4 #616

Merged
merged 2 commits into from
May 26, 2016
Merged

*: appc v0.8.4 #616

merged 2 commits into from
May 26, 2016

Conversation

jonboulle
Copy link
Contributor

No description provided.

@jonboulle jonboulle merged commit 857c30f into appc:master May 26, 2016
@elemoine
Copy link

This PR broke the installation of appc/spec for me:

$ go get github.com/appc/spec/schema
# github.com/appc/spec/schema/types
/home/elemoine/.gvm/pkgsets/go1.6/snap/src/github.com/appc/spec/schema/types/isolator_resources.go:158: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.6/snap/src/github.com/appc/spec/schema/types/isolator_resources.go:159: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.6/snap/src/github.com/appc/spec/schema/types/isolator_resources.go:212: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.6/snap/src/github.com/appc/spec/schema/types/isolator_resources.go:213: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value

@steveej
Copy link
Contributor

steveej commented May 26, 2016

This PR broke the installation of appc/spec for me:

This shouldn't happen. Please provide your go version information

Edit: Just to clarify, I don't think it's a local problem for you, but I suspect the behavior differs between go versions.

@elemoine
Copy link

$ go version
go version go1.6 linux/amd64

@jonboulle
Copy link
Contributor Author

It's because of a mismatch in versions between dependencies.
We will move appc/spec to using the vendor/ experiment which should fix
this.

On Thu, May 26, 2016 at 2:00 PM, Éric Lemoine notifications@github.com
wrote:

$ go version
go version go1.6 linux/amd64


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#616 (comment)

@elemoine
Copy link

FYI, I am seeing the same issue with go 1.5:

$ gvm install go1.5
Installing go1.5...
 * Compiling...
go1.5 successfully installed!
$ gvm use go1.5
Now using version go1.5
$ gvm pkgset create test
$ gvm pkgset use test
Now using version go1.5@test
$ go get github.com/appc/spec/schema
# github.com/appc/spec/schema/types
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:158: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:159: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:212: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:213: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value

@jonboulle
Copy link
Contributor Author

@elemoine The problem is that k8s introduced a breaking change in kubernetes/kubernetes@b2a01d4 and your go get is retrieving that version of the package. We do vendor in the repository but go get doesn't understand that because we haven't moved to the vendor experiment (yet). If you check out the repository and build using ./build it should work fine.

@elemoine
Copy link

I am quite new to Go but it seems to me that all packages that depend on appc/spec/schema are broken by this.

I initially found the problem while installing Snap (intelsdi-x/snap#953). But here's another example:

$ go get k8s.io/kubernetes/pkg/kubelet
# github.com/appc/spec/schema/types
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:158: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:159: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:212: cannot use req (type resource.Quantity) as type *resource.Quantity in field value
/home/elemoine/.gvm/pkgsets/go1.5/test/src/github.com/appc/spec/schema/types/isolator_resources.go:213: cannot use lim (type resource.Quantity) as type *resource.Quantity in field value

Sounds like a big issue to me. Not something I should work-around by checking out the repository and do ./build. No?

@jonboulle
Copy link
Contributor Author

@elemoine can you try this again now?

@elemoine
Copy link

It works. Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants