Updates limitations #420
Updates limitations #420
Conversation
|
|
||
| - Example of problematic query: | ||
| ```css | ||
| @media (min-width >= 600px) { ... } |
There was a problem hiding this comment.
This is accurate documentation, I know.
In terms of the feature... is it just silly? I get it, min-width is already a ">=" situation, it's bizarre to add an explicit ">="...
There was a problem hiding this comment.
Yeah it is just silly isn't it. I think it would be good for us to explicitly say "adding >= to min-width doesn't make sense because it is already a greater-than-or-equal comparison, so we don't support it."
| | Complex logical conditions | ⚠️ Partial / Unreliable | | ||
| | Viewport-relative units | ⚠️ Not container-aware | | ||
| | User preference queries | ❌ Unsupported (e.g., dark mode) | | ||
| | `orientation` | ❌ Unsupported | |
There was a problem hiding this comment.
Sounds like orientation and aspect-ratio are still candidates to be supported at some point, per my ticket, but this is a good documentation update.
| | User preference queries | ❌ Unsupported (e.g., dark mode) | | ||
| | `orientation` | ❌ Unsupported | | ||
| | `aspect-ratio` | ❌ Unsupported | | ||
| | Size descriptors with `>=` or `<=` | ⚠️ Not recommended | |
There was a problem hiding this comment.
| | Size descriptors with `>=` or `<=` | ⚠️ Not recommended | | |
| | Size descriptors with `>`, `<`, `>=` or `<=` | ⚠️ Not recommended | |
| #### 2. Operator and Descriptor Limitations | ||
| Some combinations of size-related descriptors and operators may not work reliably: | ||
|
|
||
| When `min-width`, `max-width`, `min-height`, or `max-height` are used with `>=` or `<=` operators. |
There was a problem hiding this comment.
| When `min-width`, `max-width`, `min-height`, or `max-height` are used with `>=` or `<=` operators. | |
| When `min-width`, `max-width`, `min-height`, or `max-height` are used with `>`, `<`, `>=` or `<=` operators. |
| | Complex logical conditions | ⚠️ Partial / Unreliable | | ||
| | Viewport-relative units | ⚠️ Not container-aware | | ||
| | User preference queries | ❌ Unsupported (e.g., dark mode) | | ||
| | `orientation` | ❌ Unsupported | |
There was a problem hiding this comment.
All unsupported query feature can be implemented using the transform method by the project owner.
transform will receive the media query and is supposed to return the new value for breakpoint preview.
In a nutshell, if this is not supported by the modules, you can still implement this yourself using the transform option.
There was a problem hiding this comment.
You make a really good point. I totally forgot about transform. That should be documented (or at least mentioned).
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR updates the breakpoint preview section of the documentation to correct inaccuracies about the limitations. Updates the spike section of PRO-6932, opening it for plugin modification.
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: