Fix findTestModule on Mocha Test

[ammein]

The issue on findTestModule is resolved by using a different type of regex :

• Windows's file path using .match() regex appears to must-have /\\\\file\\\\to\\\\path/g double backward slash that is equal to \\file\\to\\path.

I hope this issue will raise to any file path matching using regex should follow the same format as above stated.

[boutell]

Thank you!

[boutell]

Actually, for readability, I suggest that you go back to using regex literals. You don't need the RegExp constructor. You can still have an if statement that assigns one of two regexes:

if (foo) {
  regex = /something/;
} else {
  regex = /something-else/;
}

[boutell]

Also please run "npx eslint ." and fix any coding standards issues, something is complaining in the CI build (:

[boutell]

(Tip: npx eslint . --fix fixes most of them for you)

[ammein]

Sure, I'll do that 👌

[ammein]

Hi @boutell , I push the latest fixes for you.

[ammein]

Wait, it seems to be not resolved since other regex taking place on testDir.replace() . I'll have a full test again and push when everything is running smoothly.

[ammein]

Done. I think this is a major fix whereby Windows 10 produce more WTF behavior. Especially on permissions issue , I need to change the type on the third argument of fs.symlinkSync to be junction , else if not Windows 10 , use the normal dir type. Known issue has been commented on :

fs.symlink can’t create directory symlinks on Windows

Also using require("path").normalize(stringPath) seems to be much more robust and dynamic either using POSIX or Windows. And I run the test successfully after done all the fixes. Hope this is going to test on other OS as well to avoid other bugs. Let me know if you need me anything to fix on my code @boutell

[ammein]

It also needs to have attention when using Windows 10 for a unit test. The only thing that WORKS on Windows OS is to have root : module that will initialize on the current folder :

apos = require('apostrophe')({
            root : module,
            testModule: true,
            baseUrl: 'http://localhost:7780',
            modules: {
                'apostrophe-express': {
                    port: 7780
                },
            },
            afterInit: function (callback) {
                return callback(null);
            },
            afterListen: function (err) {
                assert(!err);
                done();
            }
        });

I believe this should start documented on HOWTO section on creating our own unit tests based on the OS platform. I am dreaming about making a HOWTO guideline on creating this unit tests for everyone's sake. This is a "Yahoooooo !" experience for me that it is finally working on Windows Platform that turns WTF behavior into an AWESOME experience. What do you think @boutell ?

[boutell]

Unless I miss my guess path.sep is not actually defined here, path was not required and assigned to a variable of that name (and I usually don't, because it is such a common variable name that requiring it at the top can lead to bugs; you can require it where you need it).

[ammein]

path.sep is actually a separator for file path. If POSIX, uses / , otherwise Windows uses \ . I thought using this path.sep will solve both platform or else, we could just use if else for that separator string. Anyway, path orginally defined on that file if I'm not mistaken. If not, I could use require("path").sep directly. Should I do it directly ?

[boutell]

You could log to see if I'm wrong and path.sep is a thing at that point, but if it's not yeah, require("path").sep will work fine.

…

On Sun, Sep 15, 2019 at 1:47 PM Amin Shazrin ***@***.***> wrote: path.sep is actually a separator for file path. If POSIX, uses / , otherwise Windows uses \ . I thought using this path.sep will solve both platform or else, we could just use if else for that separator string. Anyway, path orginally defined on that file id I'm not mistaken. If not, I could use require("path").sep directly. Should I do it directly ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2027?email_source=notifications&email_token=AAAH27OBDYPUAVSXJGMOL5TQJZYMHA5CNFSM4IWP4UHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XVSGI#issuecomment-531585305>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAH27KBLKTAGREUCFMLJU3QJZYMHANCNFSM4IWP4UHA> .

-- Chief Software Architect Apostrophe Technologies Pronouns: he / him / his

[ammein]

Done. I decided to use it directly to avoid incoming future bugs.

[boutell]

Thanks!