Skip to content

Commit

Permalink
Disable flaky containerd#827 test
Browse files Browse the repository at this point in the history
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
  • Loading branch information
apostasie committed Aug 28, 2024
1 parent 2dd56f5 commit b12cdf5
Showing 1 changed file with 16 additions and 6 deletions.
22 changes: 16 additions & 6 deletions cmd/nerdctl/container_commit_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,18 @@ import (
"strings"
"testing"

"gotest.tools/v3/icmd"

"github.com/containerd/nerdctl/v2/pkg/testutil"
)

/*
This test below is meant to assert that https://github.com/containerd/nerdctl/issues/827 is NOT fixed.
Obviously, once we fix the issue, it should be replaced by something that assert it works.
Unfortunately, this is flaky.
It will regularly succeed or fail, making random PR fail the Kube check.
For that reason, it is disabled, and is currently a no-op.
*/

func TestKubeCommitPush(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -62,9 +69,12 @@ func TestKubeCommitPush(t *testing.T) {
"change the expectation to 'success'.")

base.Cmd("commit", containerID, "registry.example.com/my-app:v1").AssertOK()
base.Cmd("push", "registry.example.com/my-app:v1").Assert(icmd.Expected{
ExitCode: 1,
Err: "failed to create a tmp single-platform image",
})
// See note above.
/*
base.Cmd("push", "registry.example.com/my-app:v1").Assert(icmd.Expected{
ExitCode: 1,
Err: "failed to create a tmp single-platform image",
})
*/
})
}

0 comments on commit b12cdf5

Please sign in to comment.