chore: make tests actually fail #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5668ae to
200e964
Compare
200e964 to
eabc379
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem outlined in PR #667
Apparently it is not the default behavior of
cargo testto... fail on failed tests? Commentors on this issue make it seem like this is a deep-rooted issue in cargo, which is concerning to me!Anyways... I've made a modification to our
cargo xtask testrunners that will go through each line reported bycargo testand look for failures.It will then rerun those tests and print their output so that Rover devs can actually see what's going wrong with their tests!