-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use built-in root certs #649
Conversation
Before:
With this branch,
Updated to 1.53.0 and got:
The solution was to run:
Final result:
But it is accessible via
Perhaps this has something to do with my cert store, because I seem to get similar issues from python's
At a bit of a loss here. :-/ |
OK @justinabrahms - I think it makes the most sense to just switch back to using the native-tls implementation since I other folks are also reporting issues and that is quite likely the default for a reason! Edit: I've pushed up the latest change, if you want to try again it'd be super helpful! |
…li support (#650) This change allows us to take advantage of reqwest's ability to re-use connections. Their [docs](https://docs.rs/reqwest/0.11.4/reqwest/blocking/struct.Client.html) explain that you should reuse a client by cloning it to take advantage of its internal connection pool.
96804f8
to
c930fa9
Compare
fixes #645 by switching back to the
native-tls-vendored
SSL backend instead ofrustls
, since we want to support local CAs for certain requests.This PR also includes changes from #650 that allows us to reuse the same instance of a
reqwest::blocking::Client
across the entire codebase