chore(xtask): refactor tool runners & e2e test supergraph demo #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a refactor that cleans up a bit of rushed
xtask
code.The second/third commit is the following:
make ci
There is an argument to be made here that
supergraph-demo
should live as a subdirectory inrover
if we want it to be part of our test suite, but figured that this was an easier path forward and lets us keep git history intact w/o resorting to the hellscape that is git submodules.These tests will only run in
cargo xtask test
commands and notcargo test
commands, so they should not be too much of a burden for the average contributor (they don't need to install make or docker or anything if they just runcargo test
).