WIP contribution/adding commands guide #560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559
This PR adds a new docs section,
contributing, moves the current contributing guide under it, and adds anotheradding commandsguide.The adding commands guide works off the basis of wanting to add a new
rover graph hellocommand, whose only job is to make sure a graph exists in the registry and that it's not deleted. I got through adding the command to Rover's API, but none of the request logic exists yet. I added the needed graphql operation, but not the module to actually plug into the commandI figured with the potential refactor/cleanup of
rover-client, it'd probably be best to hold off on writing down all the specifics of how to add request logic there. That combined with it being my last week (😢) means my energy and focus wasn't at its peak, so this is where I got to!