chore(ci): checks for broken links #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/lint.yml
Outdated
Comment on lines
44
to
45
| use-quiet-mode: 'yes' | ||
| use-verbose-mode: 'yes' |
There was a problem hiding this comment.
this combo seems weird at first, but what it does is:
- only show us errors that occur instead of successful links AND errors
- output full HTTP info for broken links
this config seems to be popular among other projects using this tool
lrlna
approved these changes
May 3, 2021
372644b to
7d20480
Compare
7d20480 to
f990b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #444 - also includes some fixes for broken links that it found already 😄
note: there is an option to only include files that were changed in the PR that was pushed. we could combo that config option with a daily cron that checks the whole repo for broken links.
fine with the current approach since that's what we talked about in triage but wanted to let folks know of that option :)
i've opened this issue to see if there is a way to exclude our nested
node_modulesdirectories from the ambitious link checker