feat: update sha256 section of generated releases #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the old sha256 section of our releases is likely not useful to our users as there's not really any information along with the binaries. I think we need to document how to actually compare the hashes that we've generated here to the hashes on a dev's machine.
currently it looks like this:
🛠 Maintenance
Fix something random - EverlastingBugstopper, pull/123987123987123719287312
SHA256 of release binaries for validation:
after this pr, it would look like this:
🛠 Maintenance
Fix something random - EverlastingBugstopper, pull/123987123987123719287312
This release was automatically created by Github Actions.
If you would like to verify that the binary you have downloaded was built from the source code
in this repository, you can compare the output of the commands below to the output of the same
commands on your machine.
MacOS
Binaries built for MacOS are signed and notarized, and are automatically verified with Gatekeeper.
Manual Verification:
Linux
Manual Verification:
Windows
Manual Verification:
Let me know what y'all think! I'm not sure if the commands duplicated here in the changelog are super helpful, or if maybe we should document this elsewhere.
TODO:
It actually seems like the binary hashes don't quite match up on npm so I definitely need to investigate that and figure out what's going on. Might be some weirdness with npm or with how the
binary-install
module unzips the binary it downloads from GitHub releases.