Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sha256 section of generated releases #445

Merged
merged 4 commits into from
Apr 30, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Apr 13, 2021

I realized that the old sha256 section of our releases is likely not useful to our users as there's not really any information along with the binaries. I think we need to document how to actually compare the hashes that we've generated here to the hashes on a dev's machine.

currently it looks like this:


🛠 Maintenance


SHA256 of release binaries for validation:

  • Linux: d5cdc0ff48b2c4b886e33e85b66627af31c247074393e9055fc22f40cdd3aa3d
  • Windows: 55a333a62c9295a409008b5258c91b57050b541b259bdc76bbb5ef77f6f8caa3
  • MacOS: e49f88721aec929ecf1a850e01b1460c3e987d4589faca85edf29d0bd79943ee

after this pr, it would look like this:


🛠 Maintenance


This release was automatically created by Github Actions.

If you would like to verify that the binary you have downloaded was built from the source code
in this repository, you can compare the output of the commands below to the output of the same
commands on your machine.

MacOS

Binaries built for MacOS are signed and notarized, and are automatically verified with Gatekeeper.

Manual Verification:

$ sha256sum -b $(which rover) | cut -d ' ' -f1
e49f88721aec929ecf1a850e01b1460c3e987d4589faca85edf29d0bd79943eez

Linux

Manual Verification:

$ sha256sum -b $(which rover) | cut -d ' ' -f1
d5cdc0ff48b2c4b886e33e85b66627af31c247074393e9055fc22f40cdd3aa3d

Windows

Manual Verification:

PS> Get-Command rover

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     rover.exe                                          0.0.0.0    C:\Users\username\.rover\bin\rover.exe

PS> Get-FileHash C:\Users\username\.rover\bin\rover.exe

Algorithm       Hash                                                                   Path
---------       ----                                                                   ----
SHA256          55a333a62c9295a409008b5258c91b57050b541b259bdc76bbb5ef77f6f8caa3       C:\Users\username\.rover\bin\rover.exe

Let me know what y'all think! I'm not sure if the commands duplicated here in the changelog are super helpful, or if maybe we should document this elsewhere.

TODO:

It actually seems like the binary hashes don't quite match up on npm so I definitely need to investigate that and figure out what's going on. Might be some weirdness with npm or with how the binary-install module unzips the binary it downloads from GitHub releases.

@EverlastingBugstopper EverlastingBugstopper modified the milestone: April 27 Apr 21, 2021
@EverlastingBugstopper EverlastingBugstopper added the feature 🎉 new commands, flags, functionality, and improved error messages label Apr 21, 2021
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new sha256 section. LGTM!

@EverlastingBugstopper EverlastingBugstopper merged commit 4a2a978 into main Apr 30, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/update-auto-generated-changelog branch April 30, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants