Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introspection SDL encoder #283
feat: introspection SDL encoder #283
Changes from 24 commits
31c0887
03abd1c
62150c4
dae3c8b
a8d2ea9
1942565
c23437d
f4afae0
4cba068
79d3d0a
1ecb149
32a0fd5
620a44f
d819a2c
58df7f5
9f5fbe5
9cefc86
4acd7f9
5f04444
7842198
267231b
81d0cc0
7eb7337
8217d82
85e7c85
3003986
4bfd54b
b6e68d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is empty so far, unfortunately. I am thinking of a good way to be able to run 10 or so overall tests for overall schema encoding. The problem is that I need the actual
Introspection
type that I think I can literally only get by using and making queries to the graphql_client, which is really quite bulky. If I can't come up with anything smarter, that's what I'll end up doing, I think.Help: If you can think of another clever way, please let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you manually execute introspection queries and store the results in files?
(With the old
apollo
CLI, you could get those by running something likeapollo schema:download --endpoint=http://localhost:8080/graphql schema.json
.) Or am I misunderstanding the issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you're suggesting is not possible as
Schema
is currently created for anIntrospectionResult
..json
file will not work. A.json
file would have worked ifIntrospectionResult
had aSerialize
implementation, but this implementation doesn't exist and the following code does not work:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. Since executing an introspection query against a server would return the same JSON contents, and we are able to load those into an
IntrospectionResult
, why is this different?