Skip to content

Commit

Permalink
Fix package.json to a stable version
Browse files Browse the repository at this point in the history
This way we can test what's actually important (how the installer
works). Not whether the binary exists or not.
  • Loading branch information
jonathanrainer committed Jul 10, 2024
1 parent b050603 commit 0f47878
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .circleci/scripts/install_npm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ cd "$(mktemp -d)"
echo "Created test directory"
npm init -y
echo "Initialised new npm package"
npm install --install-links=true "$SCRIPT_DIR/../../installers/npm"
cd "$SCRIPT_DIR/../../installers/npm"
npm version 0.23.0
echo "Temporarily patched package.json to fixed stable binary"
npm install --install-links=true
echo "Installed rover as local npm package"
cd node_modules/.bin/
echo "Checking version"
Expand Down
5 changes: 4 additions & 1 deletion .circleci/scripts/install_npm_global.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

cd "$(mktemp -d)"
echo "Created test directory"
npm install --install-links=true -g "$SCRIPT_DIR/../../installers/npm"
cd "$SCRIPT_DIR/../../installers/npm"
npm version 0.23.0
echo "Temporarily patched package.json to fixed stable binary"
npm install --install-links=true -g
echo "Installed rover as global npm package"
cd /usr/local/bin/
echo "Checking version"
Expand Down
3 changes: 3 additions & 0 deletions .circleci/scripts/install_pnpm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ cd "$(mktemp -d)"
echo "Created test directory"
npm install -g pnpm@v9.3.0
echo "Installed pnpm"
cd "$SCRIPT_DIR/../../installers/npm"
npm version 0.23.0
echo "Temporarily patched package.json to fixed stable binary"
pnpm init
pnpm add "file:$SCRIPT_DIR/../../installers/npm"
echo "Installed rover as pnpm package"
Expand Down

0 comments on commit 0f47878

Please sign in to comment.