-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument coprocessor request with http_request span #6776
base: dev
Are you sure you want to change the base?
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 28bbf21931d152e6d0d74026 |
0f05e85
to
2f80196
Compare
@bnjjj -- Any chance I can ask for a couple minutes of your time for a review (or point someone to me or me to someone that would be the best person to take a look at this contribution) Thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the semantic conventions for the span attributes then I think we can merge this.
Ideally we would use the existing HttpClient code for coprocessors but this is a bigger change that would be backwards compatible with what we have here.
}); | ||
let path = schema_uri.path(); | ||
|
||
let http_req_span = tracing::info_span!(HTTP_REQUEST_SPAN_NAME, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the Otel semantic conventions here: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#http-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to include required attributes for http-client spans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
6a21406
to
3f8a305
Compare
@theJC I will bring this PR into the router repo so that we can have the CI tests run. Any further changes can be made from there. |
@BrynCooke -- Bringing the branch/MR into the Router repo is not something I can do for you, is it? |
I'm ooo for the next couple of days. But I'll create the new pr when I am next at my computer. |
Instrument coprocessor request with http_request span, to be consistent in observability to subgraph http requests.
Code basically copy/pasted from apollo-router/src/services/http/service.rs
Provides Apollo's customers insight into latency that may be introduced over the network stack when communicating with coprocessor.
Fixes #6739
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Manual test:

Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩