Remove leading 0s before parsing into serde_json::Number
#6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 42b09e789001199f80796a4e |
This comment has been minimized.
This comment has been minimized.
benjamn
added a commit
that referenced
this pull request
Feb 11, 2025
We previously decided to allow leading 0s, per this discussion: #5762 (comment) However, since we use the parsing logic of `serde_json::Number` to produce the internal representation, and that logic fails given leading zeros, we need to normalize the input `&str` a bit before calling `number.parse()`. We already perform some similar normalizations, e.g. ensuring the fractional part is at least a 0 (not empty after the `.`), so there's precedent.
0510cb5 to
7a76bec
Compare
benjamn
commented
Feb 11, 2025
Comment on lines
+329
to
+332
| check_parse( | ||
| "-00", | ||
| LitExpr::Number(serde_json::Number::from_f64(-0.0).unwrap()), | ||
| ); |
There was a problem hiding this comment.
I guess negative zero has to be a float, since an integer wouldn't be able to represent the negativity?
nicholascioli
approved these changes
Feb 11, 2025
apollo-federation/src/sources/connect/json_selection/lit_expr.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+329
to
+332
| check_parse( | ||
| "-00", | ||
| LitExpr::Number(serde_json::Number::from_f64(-0.0).unwrap()), | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously decided to allow leading 0s, per this discussion.
However, since we use the parsing logic of
serde_json::Numberto produce the internal representation, and that logic fails given leading zeros, we need to normalize the input&stra bit before callingnumber.parse(). We already perform some similar normalizations, e.g. ensuring the fractional part is at least a 0 (not empty after the.), so there's precedent.Thanks to @nicholascioli for finding this problem using fuzz testing!