-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose number of evaluated query plan options #6765
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: d96c609c34403a9f43c23874 |
@dariuszkuc, please consider creating a changeset entry in |
fc0fbbd
to
a32576c
Compare
@@ -296,6 +296,8 @@ pub enum SingleFederationError { | |||
InterfaceKeyMissingImplementationType { message: String }, | |||
#[error("@defer is not supported on subscriptions")] | |||
DeferredSubscriptionUnsupported, | |||
#[error("{message}")] | |||
QueryPlanComplexityExceeded { message: String }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooooo can we have a metric in the router that tracks these as well? it can probably follow the example of max_evaluated_plans
@lrlna new metric is added to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits below, but after that it should be good to merge.
Before we start generating a query plan, we need to first evaluate all possible ways (options) that given query can be resolved. This PR exposes number of options that were considered to generate a final query plan.
Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
1af8bdf
to
9eb047f
Compare
@mergify backport 1.x |
✅ Backports have been created
|
Before we start generating a query plan, we need to first evaluate all possible ways (options) that given query can be resolved. This PR exposes number of options that were considered to generate a final query plan. (cherry picked from commit 4fe75e8)
Before we start generating a query plan, we need to first evaluate all possible ways (options) that given query can be resolved. This PR exposes number of options that were considered to generate a final query plan. Co-authored-by: Dariusz Kuc <9501705+dariuszkuc@users.noreply.github.com>
Before we start generating a query plan, we need to first evaluate all possible ways (options) that given query can be resolved. This PR exposes number of options that were considered to generate a final query plan.