Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(federation-cli): enable log printing from apollo-federation-cli (backport #6717) #6755

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 11, 2025

  • Added tracing-subscriber.
  • Filtering based on the RUST_LOG variable.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exception: Internal debugging feature


This is an automatic backport of pull request #6717 done by [Mergify](https://mergify.com).

…6717)

(cherry picked from commit ecdf1a0)

# Conflicts:
#	apollo-federation/cli/src/main.rs
@mergify mergify bot added the conflicts label Feb 11, 2025
Copy link
Contributor Author

mergify bot commented Feb 11, 2025

Cherry-pick of ecdf1a0 has failed:

On branch mergify/bp/1.x/pr-6717
Your branch is up to date with 'origin/1.x'.

You are currently cherry-picking commit ecdf1a07.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.lock
	modified:   apollo-federation/cli/Cargo.toml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   apollo-federation/cli/src/main.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@apollo-cla
Copy link

@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 11, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 28616188535354e345cbc9b6

@duckki
Copy link
Contributor

duckki commented Feb 11, 2025

We got a compliance error.
Waiting for #6756 to merge.

Copy link
Contributor

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a backport of my dev branch PR.

@duckki duckki merged commit a815e3c into 1.x Feb 11, 2025
14 checks passed
@duckki duckki deleted the mergify/bp/1.x/pr-6717 branch February 11, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants