Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce demand control allocations on start/reload #6754

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

tninesling
Copy link
Contributor

When enabled, preallocates capacity for demand control's processed schema and shrinks to fit after processing. When disabled, skips the type processing entirely to minimize startup impact.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Sorry, something went wrong.

@tninesling tninesling requested review from a team as code owners February 10, 2025 17:46
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 10, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: e18d249e1b57156e547cb3ff

This comment has been minimized.

@tninesling tninesling requested a review from a team as a code owner February 10, 2025 17:49
@tninesling tninesling merged commit 4996352 into dev Feb 11, 2025
15 checks passed
@tninesling tninesling deleted the tninesling/skip-disabled-dc-plugin branch February 11, 2025 15:13
@tninesling
Copy link
Contributor Author

@mergify backport 1.x

Copy link
Contributor

mergify bot commented Feb 11, 2025

backport 1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 11, 2025
(cherry picked from commit 4996352)
tninesling added a commit that referenced this pull request Feb 11, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…6764)

Co-authored-by: Taylor Ninesling <taylor.ninesling@apollographql.com>
@lrlna lrlna mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants