-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify path as regex in snapshots #6747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 1ece3c0f3eee50b7cfed4ecd |
@pubmodmatt, please consider creating a changeset entry in |
CI performance tests
|
994ad8e
to
26d8241
Compare
dylan-apollo
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions, but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a
regex
for the URL path in a shapshot file. This is useful when constructing tests that may result in a number of HTTP requests where responses can be reused, or where the path is dynamically generated during the test (such as a randomly generated identifier).The snapshot server first looks for an exact match to the URL path in the map, then sequentially applies each
regex
if no exact match if found. Performance could degrade if there were a lot ofregex
snapshots, but this should be reasonable for a small number of snapshots.The regular expression provided will need to escape any special characters used by the
regex
crate, such as the?
in query parameters, using\\
.The
regex
is never set when taking snapshots from the upstream API. The only way to use it is to manually edit a snapshot file, typically by converting an existing snapshot by changingpath
toregex
and replacing the variable part of the path with wilcards.These changes are backward compatible with existing snapshot files, so there is no need to update any source controlled snapshots.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩