-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove http.request.resend_count selector and attribute #6729
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: f12ef0554d5f69641f0d99d1 URL: https://www.apollographql.com/docs/deploy-preview/f12ef0554d5f69641f0d99d1 |
@bnjjj, please consider creating a changeset entry in |
CI performance tests
|
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
it was not marked as experimental. for the 1.x backport, we should still accept it in config probably, even if it's never actually present? |
@goto-bus-stop Yes I plan to make a migration, but it should be part of 1.X backport PR not this one right ? |
@@ -237,9 +237,6 @@ $_{[1]} `apollo.router.exporter.span.lru.size` now also has an additional `expor | |||
|
|||
The following metrics have been removed: | |||
|
|||
- `apollo_router_http_request_retry_total`. This will be supported now by `http.client.request.duration` metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually keep this and say the feature is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe not since we're also removing it in 1.x
It's not longer needed as we removed the retry feature
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩