Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http.request.resend_count selector and attribute #6729

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Feb 5, 2025

It's not longer needed as we removed the retry feature


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from a team as code owners February 5, 2025 09:24
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 5, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/reference/upgrade/from-router-v1.mdx

Build ID: f12ef0554d5f69641f0d99d1

URL: https://www.apollographql.com/docs/deploy-preview/f12ef0554d5f69641f0d99d1

Copy link
Contributor

github-actions bot commented Feb 5, 2025

@bnjjj, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Feb 5, 2025

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from a team as a code owner February 5, 2025 09:25
@bnjjj bnjjj requested a review from goto-bus-stop February 5, 2025 09:26
@bnjjj bnjjj added the backport-1.x Backport this PR to 1.x label Feb 5, 2025
@goto-bus-stop
Copy link
Member

it was not marked as experimental. for the 1.x backport, we should still accept it in config probably, even if it's never actually present?

@bnjjj
Copy link
Contributor Author

bnjjj commented Feb 5, 2025

@goto-bus-stop Yes I plan to make a migration, but it should be part of 1.X backport PR not this one right ?

@bnjjj bnjjj enabled auto-merge (squash) February 8, 2025 08:11
@@ -237,9 +237,6 @@ $_{[1]} `apollo.router.exporter.span.lru.size` now also has an additional `expor

The following metrics have been removed:

- `apollo_router_http_request_retry_total`. This will be supported now by `http.client.request.duration` metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually keep this and say the feature is removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe not since we're also removing it in 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.x Backport this PR to 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants