Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of other format for trace id #5735

Merged
merged 7 commits into from
Aug 1, 2024
Merged

add support of other format for trace id #5735

merged 7 commits into from
Aug 1, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jul 29, 2024

Currently we support datadog and otel traceID formats and decimal. However we would like to also support UUID.

Unify the two TraceIdFormat enums into a single enum that us used across selectors and experimental_expose_trace id.

Ensure the following formats are supported:

  • open_telemetry
  • hexadecimal (same as opentelemetry)
  • decimal
  • datadog
  • uuid (this has dashes)

Add support for logging to output using TraceIdFormat

 telemetry:
  exporters:
    logging:
      stdout:
        format:
          json:
            disaplay_trace_id: (true|false|open_telemetry|hexadecimal|decimal|datadog|uuid)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from a team as code owners July 29, 2024 09:02

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jul 29, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

bnjjj and others added 2 commits July 29, 2024 11:05
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from BrynCooke and garypen July 30, 2024 08:15
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add some tests to tests/integration/telemetry/logging.rs?

@bnjjj bnjjj requested a review from BrynCooke July 31, 2024 14:11
@bnjjj
Copy link
Contributor Author

bnjjj commented Jul 31, 2024

@BrynCooke I added 2 new integration tests

@Geal Geal self-requested a review August 1, 2024 07:56
@bnjjj bnjjj enabled auto-merge (squash) August 1, 2024 09:11
@bnjjj bnjjj dismissed BrynCooke’s stale review August 1, 2024 14:17

I need to merge this before being off and geal already approved it

@bnjjj bnjjj merged commit 49a6d7b into dev Aug 1, 2024
14 checks passed
@bnjjj bnjjj deleted the bnjjj/feat_417 branch August 1, 2024 14:17
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants