Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce "use spawn_blocking for parsing" #5644

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

abernix
Copy link
Member

@abernix abernix commented Jul 10, 2024

Important

This is ready to review once #5638 lands.

Re-lands #5582 after it was reverted in #5643 as it seems to have been causing tests to flake at a somewhat pronounced rate on dev — always on Linux. We believe it's just actually the tests, or the way we tested, but we'll revert this for now so dev isn't flaking for everyone trying to develop against it.

And worth mentioning again, this was was originally @xuorig's in #5235 which @Geal took over and @garypen ultimately landed in #5582 .

Marking this as a draft for someone to look at it.

@abernix abernix requested a review from garypen July 10, 2024 19:02
@router-perf
Copy link

router-perf bot commented Jul 10, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@garypen
Copy link
Contributor

garypen commented Jul 12, 2024

The code is fine. It was a source of testing fails because it triggered the behaviour described in #5638. As soon as #5638 merges, we should merge this.

Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5638 must merge before this.

@garypen garypen marked this pull request as ready for review July 12, 2024 13:57
@garypen garypen requested review from a team as code owners July 12, 2024 13:57
@garypen garypen marked this pull request as draft July 12, 2024 13:58
@garypen garypen marked this pull request as ready for review July 15, 2024 10:05
@garypen garypen enabled auto-merge (squash) July 15, 2024 10:06
@garypen garypen self-requested a review July 15, 2024 10:11
@garypen garypen merged commit 5b95051 into dev Jul 15, 2024
14 checks passed
@garypen garypen deleted the revert-5643-revert-5582-spawn-blocking-parser branch July 15, 2024 10:32
garypen added a commit that referenced this pull request Jul 15, 2024
Co-authored-by: Gary Pennington <gary@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants