-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce "use spawn_blocking for parsing" #5644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31f90b2.
CI performance tests
|
garypen
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5638 must merge before this.
garypen
approved these changes
Jul 15, 2024
garypen
added a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: Gary Pennington <gary@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is ready to review once #5638 lands.
Re-lands #5582 after it was reverted in #5643 as it seems to have been causing tests to flake at a somewhat pronounced rate on
dev
— always on Linux. We believe it's just actually the tests, or the way we tested, but we'll revert this for now sodev
isn't flaking for everyone trying to develop against it.And worth mentioning again, this was was originally @xuorig's in #5235 which @Geal took over and @garypen ultimately landed in #5582 .
Marking this as a draft for someone to look at it.