chore(deps): update to router-bridge containing Federation v2.3.0
#2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deno-core pinned a lot of dependencies in their latest release. In order to use router-bridge 0.1.13-beta+v2.3.0-beta.3, we need to revert renovate's work.
|
@o0Ignition0o, please add a |
Geal
reviewed
Jan 24, 2023
| @@ -2605,9 +2629,9 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "jwt-simple" | |||
| version = "0.11.2" | |||
| version = "0.11.1" | |||
There was a problem hiding this comment.
I think you rolled back a few too many dependency updates, could you reapply a cargo update and see what sticks?
There was a problem hiding this comment.
Fixed in ad17de7
There was a problem hiding this comment.
I think this stems from deno pinning their dependency on serde
router-bridge containing Federation v2.3.0
Specifically,to disambiguate against multiple versions which end up the same after removing metadata, which is something that cargo just does at some point.
Geal
approved these changes
Jan 24, 2023
abernix
approved these changes
Jan 24, 2023
o0Ignition0o
added a commit
that referenced
this pull request
Jan 25, 2023
…2462) At surface level, the motivation for this PR is to update to a version of `router-bridge` which includes Federation 2.3.0 — available as of apollographql/federation-rs#236 in `router-bridge@0.1.13-beta.0+v2.3.0-beta.3`. However, an underlying dependency, `deno_core`, has pinned a lot of dependencies in their latest release to versions which predate the versions which we now have in `apollo-router`, which we have updated to via `cargo update` and various Renovate-automated upgrades. Therefore, to make `0.1.13-beta.0+v2.3.0-beta.3` work, , we need to revert some of those dependency updates to allow the version dependencies to be resolved. Co-authored-by: Jesse Rosenberger <git@jro.cc>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At surface level, the motivation for this PR is to update to a version of
router-bridgewhich includes Federation 2.3.0 — available as of apollographql/federation-rs#236 inrouter-bridge@0.1.13-beta.0+v2.3.0-beta.3.However, an underlying dependency,
deno_core, has pinned a lot of dependencies in their latest release to versions which predate the versions which we now have inapollo-router, which we have updated to viacargo updateand various Renovate-automated upgrades.Therefore, to make
0.1.13-beta.0+v2.3.0-beta.3work, , we need to revert some of those dependency updates to allow the version dependencies to be resolved.