Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: Unpin schemars version. #1135

Merged
merged 2 commits into from
May 24, 2022
Merged

maintenance: Unpin schemars version. #1135

merged 2 commits into from
May 24, 2022

Conversation

o0Ignition0o
Copy link
Contributor

Fixes #1074

The Schemars 0.8.9 caused compile errors due to it validating default types.
This change has however been rolled back upstream.
We can now safely depend on schemars 0.8.10.

Fixes #1074

The Schemars 0.8.9 caused compile errors due to it validating default types.
This change has however been rolled back upstream.
We can now safely depend on schemars 0.8.10.
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit fbc0c2b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/628c985ddafdf200084d6abf

@o0Ignition0o o0Ignition0o marked this pull request as ready for review May 24, 2022 08:35
@o0Ignition0o o0Ignition0o requested review from BrynCooke, garypen, Geal, SimonSapin and bnjjj and removed request for BrynCooke and garypen May 24, 2022 08:35
@o0Ignition0o o0Ignition0o merged commit eeef38e into main May 24, 2022
@o0Ignition0o o0Ignition0o deleted the igni/unpin_schemars branch May 24, 2022 09:43
@garypen garypen mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schemars update breaks compilation
3 participants