Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: sharing headers between subgraphs #2128

Closed
abernix opened this issue Nov 18, 2022 · 0 comments · Fixed by #2446
Closed

docs: sharing headers between subgraphs #2128

abernix opened this issue Nov 18, 2022 · 0 comments · Fixed by #2446
Assignees
@BrynCooke
Labels
documentation Improvements or additions to documentation

Comments

@abernix
Copy link
Member

abernix commented Nov 18, 2022 •
edited
Loading

Currently, our documentation talks about sending headers from clients to subgraphs, but doesn't frame the (achievable!) solution to threading headers between subgraphs.

There's some art that exemplifies this behavior in #2021 which can be referred to.
@abernix abernix added the documentation Improvements or additions to documentation label Nov 18, 2022
@BrynCooke BrynCooke self-assigned this Jan 20, 2023
BrynCooke pushed a commit that referenced this issue Jan 20, 2023
Add docs for subgraph header propagation
98fcb41 
Fix #2128
@BrynCooke BrynCooke mentioned this issue Jan 20, 2023
Merged
6 tasks
BrynCooke pushed a commit that referenced this issue Jan 20, 2023
Add docs for subgraph header propagation
9db7e84 
Fix #2128
BrynCooke pushed a commit that referenced this issue Jan 20, 2023
Add docs for subgraph header propagation
b17ac08 
Fix #2128
BrynCooke added a commit that referenced this issue Jan 24, 2023
@BrynCooke
Add docs for subgraph header propagation (#2446)
d3c5383 
- Fix #2128
Propagation for headers between subgraphs is now documented.

In addition #2444 has been raised to track a potential future where this
can be achieved via YAML.

**Checklist**

Complete the checklist (and note appropriate exceptions) before a final
PR is raised.

- [ ] ~~Changes are compatible[^1]~~
- [x] Documentation[^2] completed
- [ ] ~~Performance impact assessed and acceptable~~
- Tests added and passing[^3]
    - [ ] ~~Unit Tests~~
    - [ ] ~~Integration Tests~~
    - [x] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]. It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding
Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or
ask for it to be labeled) as `manual test`

Co-authored-by: bryn <bryn@apollographql.com>
@abernix abernix mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docs for subgraph header propagation apollographql/router
2 participants
@BrynCooke @abernix