Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Revert 27cc028 (https://github.com/apollographql/react-apollo/pull/1983) #2432

Merged
merged 4 commits into from
Sep 28, 2018
Merged

Revert 27cc028 (https://github.com/apollographql/react-apollo/pull/1983) #2432

merged 4 commits into from
Sep 28, 2018

Conversation

hwillson
Copy link
Member

@hwillson hwillson commented Sep 28, 2018 •
edited
Loading

#1983 turned out to be breaking for many Typescript users. Rolling back those changes, and we'll find another way to get something similar in place.

Fixes #2424.

@hwillson hwillson merged commit 969460f into master Sep 28, 2018
@hwillson hwillson deleted the hwillson/revert-27cc028 branch September 28, 2018 11:36
hwillson added a commit that referenced this pull request Sep 28, 2018
@hwillson
Test changes to ensure type guard isn't needed on result data
320edd2 
test suite. These changes were rolled back in #2432, but this
test change should help prevent this same issue from happening
again.

Reference: #2424
@hwillson hwillson mentioned this pull request Sep 28, 2018
Merged
hwillson added a commit that referenced this pull request Sep 28, 2018
@hwillson
Test changes to ensure type guard isn't needed on result data (#2434)
539b9a8 
#1983 introduced breaking changes that were missed by the current test suite. These changes were rolled back in #2432, but this test change should help prevent this same issue from happening
again.

Reference: #2424
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hwillson