Better polyfill for globalThis. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horrifying, sure, but much better than using Function: https://mathiasbynens.be/notes/globalthis Fixes #23.
|
Haha, nice! I'd say go for it! |
Yes, I bloody forgot to add github repo details in the package .... will do now. |
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Dec 4, 2020
apollographql/invariant-packages#53 This may also help with issues like #7406, where a _patch_ version update (from 0.5.0 to 0.5.1) is not enough to force a dependency like ts-invariant with multiple conflicting version constraints (from @apollo/client and graphql-tools) to be updated, since version 0.5.0 is still semantically compatible with the desired minimum version 0.5.1, so ts-invariant remains outdated after updating @apollo/client, despite the new version being clearly mandated in @apollo/client/package.json. After updating the _minor_ version of ts-invariant in package.json (to ^0.6.0), there should be no risk of @apollo/client incorrectly resolving the older ts-invariant@0.5.0 version.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Dec 4, 2020
apollographql/invariant-packages#53 This update may also help with issues like #7406, where a patch version update (from 0.5.0 to 0.5.1) is apparently not enough to force a dependency like ts-invariant with multiple conflicting version constraints (from @apollo/client and graphql-tools) to be updated, since version 0.5.0 is still semantically compatible with the desired minimum version 0.5.1, so ts-invariant remains outdated after updating @apollo/client, despite the new version being clearly mandated in @apollo/client/package.json. After updating the minor version of ts-invariant in package.json (to ^0.6.0), there should be no risk of @apollo/client incorrectly resolving the older ts-invariant@0.5.0 version, though there may end up being multiple copies of ts-invariant in node_modules with different versions, which is fine for this particular package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Horrifying, sure, but so much better than using
Function, in terms of how many folks will complain it violates their Content Security Policy: https://mathiasbynens.be/notes/globalthisMerging and releasing this PR will give the
@ungap/global-thispolyfill 500x more weekly downloads.@mathiasbynens @WebReflection Any words of caution?
Fixes #23.