Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly identify that graphql-tag doesn't have side effects #313

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

hwillson
Copy link
Member

This will help tree-shaking when used with projects that have a dependency on graphql-tag (like @apollo/client).

Reference: apollographql/apollo-client#6687

This will help tree-shaking when used with projects that have a
dependency on `graphql-tag` (like `@apollo/client`).

Reference: apollographql/apollo-client#6687
@hwillson hwillson requested a review from benjamn July 28, 2020 15:30
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwillson hwillson merged commit fbbb02e into master Jul 28, 2020
@hwillson hwillson deleted the side-effects branch July 28, 2020 15:32
benjamn added a commit to apollographql/apollo-client that referenced this pull request Jul 28, 2020
@Akxe
Copy link

Akxe commented Aug 5, 2020

Did not work for me:

WARNING in C:\Users\akxe\Documents\Programming\rita\apps\rita-shop\src\graphql\apollo.service.ts depends on 'graphql-tag'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

package-lock.json (extract)

"graphql-tag": {
  "version": "2.11.0",
  "resolved": "https://registry.npmjs.org/graphql-tag/-/graphql-tag-2.11.0.tgz",
  "integrity": "sha512-VmsD5pJqWJnQZMUeRwrDhfgoyqcfwEkvtpANqcoUG8/tOLkwNgU9mzub/Mc78OJMhHjx7gfAMTxzdG43VGg3bA=="
},

@ahmadalfy
Copy link

Yup, still doesn't work

WARNING in /src/app/_services/upload.service.ts depends on 'graphql-tag'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants