Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gql typings #289

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix gql typings #289

merged 1 commit into from
Feb 5, 2020

Conversation

Guillaumez
Copy link
Contributor

It seems that the typings from v2.10.2 are not exactly as expected.

Based on what i see in the gql function, it seems that the literals parameter accepts an array of strings or a string.

@apollo-cla
Copy link

@Guillaumez: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guillaumez - I'll add this in. We would like to change this to not be necessary, but we'll do that in a future release.

@hwillson hwillson merged commit 40c657b into apollographql:master Feb 5, 2020
@dotansimha
Copy link
Contributor

Awesome :) The changes in 2.10.2 were breaking for us (in graphql-code-generator), we had to change the function usage to be gql([str]) instead of gql(str). This seems to fix that :)

Thanks @Guillaumez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants