feat(federation): Initial support for @tag and @inaccessible in composition
#756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broke something on value types - presumably an implicit dependency on `field.extensions.federation` not existing (when now it does)
The changes we made to include applied directives on the field metadata broke a hacky workaround we used to include `@join_field(graph:)` on fields of the owning service, and our fix of that broke `@provides` on fields of value types. This commit cleans up the code a bit so we replicate the previous behavior in a more straightforward way.
martijnwalraven
requested changes
May 13, 2021
martijnwalraven
approved these changes
May 18, 2021
There was a problem hiding this comment.
I think this is ready to be merged. Before the next release, I do think we may want to avoid outputting directive definitions for @inaccessible and @tag to avoid changes to every composed schema even if these aren't used. And we still need to define core features for @inaccessible and @tag. But I can do that as part of the core schema work that I've started on top of this. That doesn't have to block this PR I think.
trevor-scheer
added a commit
that referenced
this pull request
Jun 24, 2021
…omposition (#756) Introduce the existence and composition of the @tag and @inaccessible directives,to be printed in `supergraphSdl` and used for schema filtering.
trevor-scheer
added a commit
that referenced
this pull request
Jul 6, 2021
…omposition (#756) Introduce the existence and composition of the @tag and @inaccessible directives,to be printed in `supergraphSdl` and used for schema filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the existence and composition of the
@tagand@inaccessibledirectives,to be printed in
supergraphSdland used for schema filtering.TODO: