Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway-js: Add onSchemaLoadOrUpdate() method to register listeners for schema loads/updates and give them the core supergraph SDL #738

Merged
merged 8 commits into from
Jul 22, 2021
+227 −185
Merged

gateway-js: Add onSchemaLoadOrUpdate() method to register listeners for schema loads/updates and give them the core supergraph SDL #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56666fa
Factor out common code between loadStatic() and loadDynamic(), and fi…
sachindshinde May 6, 2021
b80671e
Pass supergraph SDL to schema change listeners
sachindshinde May 6, 2021
f2f1d60
Run prettier
sachindshinde May 6, 2021
8b95c72
Add new method onSchemaLoadOrUpdate() to replace onSchemaChange(), an…
sachindshinde May 19, 2021
5285993
Move queryPlanStore.flush() to inside updateWithSchemaAndNotify()
sachindshinde May 21, 2021
882a8e3
Update CHANGELOG.md
sachindshinde May 22, 2021
459e713
Add TODO about "schema derived state"
sachindshinde May 22, 2021
c80ac2b
Update CHANGELOG.md to highlight discrepancy between onSchemaChange a…
sachindshinde May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gateway-js/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.

- _Nothing yet! Stay tuned!_
- Fixes bug where one `onSchemaChange` listener throwing would prevent other `onSchemaChange` listeners from being notified. [PR #738](https://github.com/apollographql/federation/pull/738)
- Adds `onSchemaLoadOrUpdate` method to register listeners for schema load and updates, and to receive both the API schema and the core supergraph SDL. `onSchemaChange` has been deprecated in favor of this method. Note that `onSchemaChange` listeners are not notified when loading schemas from static gateway configurations, while `onSchemaLoadOrUpdate` listeners are notified. [PR #738](https://github.com/apollographql/federation/pull/738)

## v0.34.0

Expand Down
Loading