Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): test Node.js v16 and expand "engines" range to include it #713

Merged
merged 14 commits into from
May 3, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ jobs:
type: executor
executor: << parameters.platform >>
environment:
# Note: This is a no-op at the second, but bear with me on this. If this
# comment is not removed by 2021-06-30 remove it along with the next line.
# renovate: datasource=github-tags depName=nodejs/node versioning=node
NODE_VERSION: 14.16.1
NPM_VERSION: 7.10.0
steps:
Expand Down
15 changes: 15 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,21 @@
"apollo-open-source"
],
"dependencyDashboard": true,
// The "circleci" manager is intentionally disabled right now (e.g., not
// included in this list). While we do benefit from its updating of "Orb"
// versions, the CircleCI manager also attempts to update Docker images using
// its "Docker" datasource. This is really handy, in theory, but we have
// intentionally varying major Node.js docker image identifiers in our
// CircleCI configuration to test on each major Node.js platform. Enabling
// the "circleci" manager would cause all of these to update to the latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not trying to verify whether this is true or not (I kinda hope it's actually not hard to tell it not to take major version bumps), happy to move forward with circleci disabled for now even if there's a chance you're being overly conservative.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it's easy to tell it to not take major version bumps for this file, yes.

// version (e.g., 16) when we want them to be intentionally different!
// I'm going to try to craft an fix for this, but I might do it upstream
// on Renovate itself using its Regex manager. It's also worth noting that
// there is other configuration that could be used to _only_ renovate "orbs"
// on this file, but I'm taking the short-cut route and not juggling with
// that right now. I can test the repository locally with my own copy of
// Renovate and come up with another solution given some free time. -Jesse
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"enabledManagers": ["npm", "cargo"],
"packageRules": [
// We set this to the lowest supported Node.js version to ensure we don't
// use newer Node.js APIs unknowingly during development which are going to
Expand Down