-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(infra): test Node.js v16 and expand "engines" range to include it #713
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f308e63
chore(infra) Upgrade monorepo to use npm@7 and enable `engines-strict`.
abernix a46cdec
infra(ci): Switch to using `cimg/` Docker images over `circleci/` images
abernix 24fb005
docs: Switch to using `NODE_VERSION` and `NPM_VERSION` for Netlify
abernix 7b8371b
infra: Start running Node.js 16 tests
abernix e663ea0
chore: bump upper-bounds of `node` within `engines` to allow Node.js v16
abernix d18145c
Remove unnecessary `engines` constraint on unpublished package
abernix cdb5855
renovate: Intentionally disable the `circleci` manager
abernix e25349b
infra(ci): Adjust Windows CI job parameters
abernix 3874b15
Merge remote-tracking branch 'origin/main' into abernix/npm7
abernix 0bd9b10
Merge branch 'abernix/npm7' into abernix/node-16
abernix 5560301
Update npm 7 for docs again after weekend Renovations.
abernix b403223
Merge branch 'abernix/npm7' into abernix/node-16
abernix c126456
Merge remote-tracking branch 'origin/main' into abernix/node-16
abernix 6d84a44
Add CHANGELOG.md.
abernix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,21 @@ | |
"apollo-open-source" | ||
], | ||
"dependencyDashboard": true, | ||
// The "circleci" manager is intentionally disabled right now (e.g., not | ||
// included in this list). While we do benefit from its updating of "Orb" | ||
// versions, the CircleCI manager also attempts to update Docker images using | ||
// its "Docker" datasource. This is really handy, in theory, but we have | ||
// intentionally varying major Node.js docker image identifiers in our | ||
// CircleCI configuration to test on each major Node.js platform. Enabling | ||
// the "circleci" manager would cause all of these to update to the latest | ||
// version (e.g., 16) when we want them to be intentionally different! | ||
// I'm going to try to craft an fix for this, but I might do it upstream | ||
// on Renovate itself using its Regex manager. It's also worth noting that | ||
// there is other configuration that could be used to _only_ renovate "orbs" | ||
// on this file, but I'm taking the short-cut route and not juggling with | ||
// that right now. I can test the repository locally with my own copy of | ||
// Renovate and come up with another solution given some free time. -Jesse | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to self: Another option might be https://docs.renovatebot.com/configuration-options/#matchcurrentversion. |
||
"enabledManagers": ["npm", "cargo"], | ||
"packageRules": [ | ||
// We set this to the lowest supported Node.js version to ensure we don't | ||
// use newer Node.js APIs unknowingly during development which are going to | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not trying to verify whether this is true or not (I kinda hope it's actually not hard to tell it not to take major version bumps), happy to move forward with circleci disabled for now even if there's a chance you're being overly conservative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it's easy to tell it to not take major version bumps for this file, yes.