Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: federation overview #3205

Merged
merged 6 commits into from
Jan 29, 2025
Merged

docs: federation overview #3205

merged 6 commits into from
Jan 29, 2025

Conversation

shorgi
Copy link
Contributor

@shorgi shorgi commented Jan 27, 2025 •
edited
Loading

On federation overview page:

  • Add benefit for connecting APIs declaratively
  • Prioritize connectors quickstart
  • Emphasize orchestration
  • Link to Odyssey connectors course

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f322de0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 27, 2025 •
edited
Loading

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed 
* graphos/schema-design/federated-schemas/federation.mdx

Build ID: cbf0026126dabda576dbfc3e

URL: https://www.apollographql.com/docs/deploy-preview/cbf0026126dabda576dbfc3e

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 27, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shorgi shorgi changed the title [WIP] docs: federation intro docs: federation overview Jan 29, 2025
@shorgi shorgi marked this pull request as ready for review January 29, 2025 21:44
@shorgi shorgi requested a review from a team as a code owner January 29, 2025 21:44
Meschreiber
Meschreiber reviewed Jan 29, 2025
View reviewed changes
docs/source/schema-design/federated-schemas/federation.mdx
Comment on lines 13 to 14
<img src='../../images/federation.svg' class="dark:hidden"/>
<img src='../../images/federation-dark.svg' class="hidden dark:block"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace this diagram with one that includes connectors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, we can update in follow-up PR

shorgi and others added 2 commits January 29, 2025 14:39
@shorgi @Meschreiber
Update docs/source/schema-design/federated-schemas/federation.mdx
d914c98 
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
@shorgi
from review comment, use OdysseyCallout
ca26eeb
@shorgi @Meschreiber
Update docs/source/schema-design/federated-schemas/federation.mdx
f322de0 
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
@shorgi shorgi merged commit a8c3fd2 into main Jan 29, 2025
17 checks passed
@shorgi shorgi deleted the eh/DOC-325/fed-conn-intro branch January 29, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meschreiber Meschreiber Meschreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shorgi @svc-apollo-docs @Meschreiber