Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary array copying in ConditionValidationState.advance() #3109

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Avoid unnecessary array copying in ConditionValidationState.advance() #3109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efdce1e
Remove concat() from ConditionValidationState.advance(), which greatl…
sachindshinde Aug 7, 2024
c08c2f9
Add changeset
sachindshinde Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fast-points-wonder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@apollo/federation-internals": patch
"@apollo/gateway": patch
"@apollo/composition": patch
---

Reduce memory overhead during satisfiability checking when there are many options.
4 changes: 2 additions & 2 deletions query-graphs-js/src/conditionsValidation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ConditionValidationState {
) {}

advance(supergraph: Schema): ConditionValidationState[] | null {
let newOptions: SimultaneousPathsWithLazyIndirectPaths[] = [];
const newOptions: SimultaneousPathsWithLazyIndirectPaths[] = [];
for (const paths of this.subgraphOptions) {
const pathsOptions = advanceSimultaneousPathsWithOperation(
supergraph,
Expand All @@ -40,7 +40,7 @@ class ConditionValidationState {
if (!pathsOptions) {
continue;
}
newOptions = newOptions.concat(pathsOptions);
newOptions.push(...pathsOptions);
}

// If we got no options, it means that particular selection of the conditions cannot be satisfied, so the
Expand Down