Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put join__enumValue onto an EnumValue if all subgraphs who have the enum have the value #3054

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

clenfest
Copy link
Contributor

No description provided.

@clenfest clenfest requested a review from a team as a code owner June 28, 2024 14:03
Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 72bb57f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/composition Patch
@apollo/gateway Patch
@apollo/federation-internals Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 72bb57f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667ec2b32574070008b3c05b

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest merged commit a4e105e into main Jun 28, 2024
19 checks passed
@clenfest clenfest deleted the clenfest/avoid_joinEnumValue branch June 28, 2024 17:53
sachindshinde added a commit that referenced this pull request Jul 8, 2024
…who have the enum have the value (#3054)"

This reverts commit a4e105e.
@sachindshinde sachindshinde mentioned this pull request Jul 8, 2024
sachindshinde added a commit that referenced this pull request Jul 8, 2024
This PR reverts #3054, as this changes the output of composition for most users and should instead land in `next` instead of `main`.
Meschreiber pushed a commit that referenced this pull request Jul 9, 2024
Meschreiber pushed a commit that referenced this pull request Jul 9, 2024
This PR reverts #3054, as this changes the output of composition for most users and should instead land in `next` instead of `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants