Fix generating misleading "value type" hint on entity interfaces #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that generates the `INCONSISTENT_INTERFACE_VALUE_TYPE_FIELD` was run inconditionally on all interfaces. However, with the introduction of `@interfaceObject` and `@key` on interfaces, we now essentially support "entity" interfaces, and it is misleading to generate this hint for those interfaces. This commit fixes that. Fixes apollographql#2397
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: d32738a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
approved these changes
Feb 21, 2023
This was referenced Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that generates the
INCONSISTENT_INTERFACE_VALUE_TYPE_FIELDwas run inconditionally on all interfaces. However, with the introduction of@interfaceObjectand@keyon interfaces, we now essentially support "entity" interfaces, and it is misleading to generate this hint for those interfaces. This commit fixes that.Fixes #2397