-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tag spec v0.3 #2314
Add support for tag spec v0.3 #2314
Conversation
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Can you push some changelog entries (in subgraphs-js/CHANGELOG.md
and gateway-js/CHANGELOG.md
ideally)?
…ns are valid for gateway)
…ich declares the latest version of the tag definition for subgraphs, but isn't really used by our code)
…e where it was mistakenly using tag v0.2 spec for Fed 1, but going to keep old behavior until we run more tests
f33af31
to
7b88b70
Compare
@pcmanus |
Hi all, I've upgrade form @apollo/subgraph from "@tag" should have locations field_definition, object, interface, union, argument_definition, scalar, enum,
enum_value, input_object, input_field_definition, but found (non-subset) field_definition,
object, interface, union, argument_definition, scalar, enum, enum_value, input_object,
input_field_definition, schema It seems this change will breaking existing directives. Is there any guid for migration without breakage that we the community could have a reference to ? |
@geekmini Thanks for writing in! Your error looks similar to that reported in #2375 . We've written up some guidance in #2375 (comment) , can you let us know whether that resolves the issue? |
Hi @sachindshinde yup, upgrade the federation version solves the issue. BTW, I am using Nest.Js as framwork |
This PR:
SCHEMA
location in the@tag
directive definition.SUPPORTED_FEATURES
to include tag v0.3 (which controls supported features during supergraph schema processing).@tag
directive definition of tag spec v0.3.@tag
directive definition of tag spec v0.2).@tag
directive definition of tag spec v0.1 for Fed 1 instead of v0.2, but I'm guessing it's benign given no one's complained thus far (and we'd have to run checks if we wanted to change the behavior).TagDirective
in@apollo/subgraph
to use the@tag
directive definition of tag spec v0.3.