-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make queryPlanStoreKey a hash of both the query and Operation name #2310
Make queryPlanStoreKey a hash of both the query and Operation name #2310
Conversation
@AneethAnand: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thanks for submitting a pull request! Linking this to the original issue, so that we can review more thoroughly. |
d7d5e69
to
fcb10d2
Compare
🦋 Changeset detectedLatest commit: 224e18e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@AneethAnand can you please implement the change that Sylvain requested and add a patch changeset? |
…nand/federation into federation/MakeInitQPStorePublic
Incorporated your review comments! Thanks again for your inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AneethAnand!
…he query and Operation name
Fixes #2309