Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for node@18 #1930

Merged
merged 6 commits into from
Oct 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ commands:
common_test_steps:
description: "Commands run on each Node.js job"
steps:
- oss/install_specific_npm_version:
version: '7'
- checkout
- oss/npm_clean_install_with_caching
- run:
Expand All @@ -39,7 +37,7 @@ jobs:

NodeJS 12:
docker:
- image: cimg/node:12.22.1
- image: cimg/node:12.22
steps:
- common_test_steps
# We will save the results of this one particular invocation to use in
Expand All @@ -54,25 +52,25 @@ jobs:

NodeJS 14:
docker:
- image: cimg/node:14.16.1
- image: cimg/node:14.19
steps:
- common_test_steps

NodeJS 16:
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.15
steps:
- common_test_steps
NodeJS 17:

NodeJS 18:
docker:
- image: cimg/node:17.0.0
- image: cimg/node:18.2.0
steps:
- common_test_steps

GraphQL v15 Support:
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.18.0
steps:
- oss/install_specific_npm_version:
version: '7'
Expand All @@ -93,10 +91,8 @@ jobs:
GraphQL Types:
description: "Assert generated GraphQL types are up to date"
docker:
- image: cimg/node:14.16.1
- image: cimg/node:16.15
steps:
- oss/install_specific_npm_version:
version: '7'
- checkout
- oss/npm_clean_install_with_caching
- run:
Expand Down Expand Up @@ -137,10 +133,11 @@ workflows:
- NodeJS 16:
name: "JS: Node 16"
<<: *common_non_publish_filters
- NodeJS 18:
name: "JS: Node 18"
<<: *common_non_publish_filters
- GraphQL v15 Support:
name: "Backcompat support: graphql@15"
- NodeJS 17:
name: "JS: Node 17"
<<: *common_non_publish_filters
- GraphQL Types:
name: "GraphQL Types (up to date)"
Expand All @@ -152,7 +149,7 @@ workflows:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 17"
- "JS: Node 18"
- "Backcompat support: graphql@15"
- "GraphQL Types (up to date)"
- oss/dry_run:
Expand All @@ -162,7 +159,7 @@ workflows:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 17"
- "JS: Node 18"
- "Backcompat support: graphql@15"
- "GraphQL Types (up to date)"
- oss/confirmation:
Expand Down
1 change: 1 addition & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@
},
"typescript.tsdk": "./node_modules/typescript/lib",
"typescript.enablePromptUseWorkspaceTsdk": true,
"task.allowAutomaticTasks": "on",
}
4 changes: 1 addition & 3 deletions federation-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.

- _Nothing yet! Stay tuned._
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.36.1

Expand Down
2 changes: 1 addition & 1 deletion federation-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "MIT",
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 1 addition & 2 deletions gateway-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. The Federation v2 equivalent for this package can be found [here](https://github.com/apollographql/federation/blob/main/gateway-js/CHANGELOG.md) on the `main` branch of this repo.

## vNEXT
> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually)

- Nothing yet! Stay tuned.
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.52.1
- The change released in v0.52.0 which updates the TypeScript types relating to the gateway interface has been improved to be more compatible with Apollo Server 2. [PR #2080](https://github.com/apollographql/apollo-server/pull/2080)
Expand Down
2 changes: 1 addition & 1 deletion gateway-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"license": "MIT",
"publishConfig": {
Expand Down
3 changes: 3 additions & 0 deletions gateway-js/src/__generated__/graphqlTypes.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions lerna-debug.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
0 silly argv {
0 silly argv _: [ 'run' ],
0 silly argv stream: true,
0 silly argv lernaVersion: '4.0.0',
0 silly argv '$0': '/Users/jeff/source/apollographql/federation/node_modules/.bin/lerna',
0 silly argv script: 'monorepo-prepare'
0 silly argv }
1 notice cli v4.0.0
2 verbose rootPath /Users/jeff/source/apollographql/federation
3 info versioning independent
4 error JSONError: Unexpected token "<" (0x3C) in JSON at position 710 while parsing near ".../query-planner-js\",\n<<<<<<< HEAD\n \"@a..." in gateway-js/package.json
4 error
4 error   29 | "@apollo/federation": "file:../federation-js",
4 error   30 | "@apollo/query-planner": "file:../query-planner-js",
4 error > 31 | <<<<<<< HEAD
4 error   | ^
4 error   32 | "@apollo/utils.createhash": "^1.1.0",
4 error   33 | =======
4 error   34 | "@apollo/server-gateway-interface": "^1.0.2",
4 error
4 error at parseJson (/Users/jeff/source/apollographql/federation/node_modules/parse-json/index.js:29:21)
4 error at parse (/Users/jeff/source/apollographql/federation/node_modules/load-json-file/index.js:15:9)
4 error at module.exports (/Users/jeff/source/apollographql/federation/node_modules/load-json-file/index.js:18:47)
64 changes: 51 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"codegen:check": "npm run codegen && git diff --exit-code"
},
"engines": {
"node": ">=12.13.0 <18.0",
"node": ">=12.13.0",
"npm": ">=7 <9"
},
"dependencies": {
Expand Down
4 changes: 1 addition & 3 deletions query-planner-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.

- _Nothing yet! Stay tuned._
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.10.2

Expand Down
2 changes: 1 addition & 1 deletion query-planner-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"license": "MIT",
"publishConfig": {
Expand Down
4 changes: 1 addition & 3 deletions subgraph-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the `0.x` range. T

## vNEXT

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.

- Nothing yet! Stay tuned.
- Expand support for Node.js v18 [PR #1884](https://github.com/apollographql/federation/pull/1884)

## v0.4.2

Expand Down
2 changes: 1 addition & 1 deletion subgraph-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "MIT",
"engines": {
"node": ">=12.13.0 <18.0"
"node": ">=12.13.0"
},
"publishConfig": {
"access": "public"
Expand Down