Fix operation names #1568
Merged
Fix operation names #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
benweatherman
approved these changes
Mar 7, 2022
pcmanus
pushed a commit
that referenced
this pull request
Mar 8, 2022
Followup to #1568, where I misread the documentation of the `replace` function, expecting it to replace all occurrences when it doesn't (unless using a regexp with the `g` flag, which this patch does).
trevor-scheer
added a commit
that referenced
this pull request
Mar 16, 2022
trevor-scheer
added a commit
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1550: as mentioned in my last comment, that PR adds the subgraph names to the operation name, but we unfortunately allow near anything as a subgraph name, and so in particular we can have subgraph names that are invalid graphQL names. in which case the query plan we generate ends up invalid.
This PR "sanitize" the subgraph name (the other part we use for the operation name is the name of the original query, but we know that is a valid graphQL name by definition). It also switch from a single
_to__to separate the elements from the generate operation names so it's a bit clearer if some underscores are already used for either the original query name or the subgraph name.