add core defs to in buildSubgraphSchema

[queerviolet]

always emit a core schema from buildSubgraphSchema for fed v2 schemas.

fed v1 schemas will not have core markings added, but will have any missing definitions of federation directives filled in

[netlify]

✅ Deploy Preview for apollo-federation-docs canceled.

Name	Link
🔨 Latest commit	ad45d01
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-federation-docs/deploys/625051f9cafe3f00085201f5

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[queerviolet]

ptal, i think this is ready to go

[benweatherman]

🐐

[queerviolet]

thanks!

[ruben-nogueira]

After upgrading to 2.0.0-preview.12 I'm getting those errors.

Error: Must provide only one schema definition.

There can be only one query type in schema.

There can be only one mutation type in schema.

Those types are using the extend type Query or extend type Mutation (we have some of them). @queerviolet Can you please confirm if it's related with PR? Thanks!

[cpeacock]

Hi @ruben-nogueira! Could you open another issue and/or please send me your generated supergraph schemas? These errors seem to be coming from graphql-js, which probably means there's a duplication of the schema definition somewhere or something similar, we're taking a look at it.

[ruben-nogueira]

@cpeacock thanks for your response. I created a new issue here: #1703