Fix TS / runtime errors while using graphql@15
#1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
approved these changes
Feb 8, 2022
Comment on lines
+84
to
+102
| GraphQL v15 Support: | ||
| docker: | ||
| - image: cimg/node:16.0.0 | ||
| steps: | ||
| - oss/install_specific_npm_version: | ||
| version: '7' | ||
| - checkout | ||
| - run: | ||
| command: npm i -D graphql@15.8.0 | ||
| - run: | ||
| command: npm run clean && npm i | ||
| - run: | ||
| command: npm run test:ci | ||
| environment: | ||
| JEST_JUNIT_OUTPUT_DIR: "reports/junit/" | ||
| - store_test_results: | ||
| path: reports/junit | ||
| - store_artifacts: | ||
| path: reports/junit |
There was a problem hiding this comment.
@abernix I'd be curious to hear if you have any opinions on this. We've run into a couple v15 compat issues, this particular version straddle has a few gotchas. Seems like a reasonable way to catch this in CI.
I found the npm run clean && npm i to work around a problem where it seemed the TS build was out of date (probably was via the caching, which this breaks/works around). Maybe there's a better way that's still cacheable?
subgraph-js/package.json
Outdated
| @@ -23,7 +23,10 @@ | |||
| "publishConfig": { | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "apollo-server-types": "^0.9.0 || ^3.0.0" | |||
There was a problem hiding this comment.
I had to add it to get it to work, but I'm not sure why.
graphql@15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like that although OperationTypeNode existed as an exported type in graphql15, it did not exist as an enum, so the way I'm using it is incorrect in peer dependencies.
Fixes #1481