Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subgraph): support @contact directive in printSubgraphSchema #1096

Merged
merged 9 commits into from
Nov 20, 2021
Merged

fix(subgraph): support @contact directive in printSubgraphSchema #1096

merged 9 commits into from
Nov 20, 2021

Conversation

lennyburdette
Copy link
Contributor

@lennyburdette lennyburdette commented Oct 15, 2021 •
edited by trevor-scheer
Loading

Print @contact directive on schema nodes from the printSubgraphSchema function

Fixes #1094

@lennyburdette lennyburdette mentioned this pull request Oct 15, 2021
Closed
@trevor-scheer trevor-scheer force-pushed the schema-directives branch 2 times, most recently from 53b0b88 to 92fcec5 Compare November 4, 2021 20:12
@trevor-scheer trevor-scheer marked this pull request as ready for review November 4, 2021 20:13
@trevor-scheer trevor-scheer changed the title fix: support schema directives in printSubgraphSchema fix(subgraph): support @contact directive in printSubgraphSchema Nov 4, 2021
@lennyburdette
Copy link
Contributor Author

New directive buckets and comments are very clear and helpful!

glasser
glasser approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the suggestion I sent you in Slack! I think this is a lot easier to wrap my head around.

federation-js/src/composition/compose.ts Outdated Show resolved Hide resolved
lennyburdette and others added 8 commits November 19, 2021 16:17
@lennyburdette @trevor-scheer
fix: support schema directives in printSubgraphSchema
28fd632 
This requires a change to apollo-graphql as well: apollographql/apollo-tooling#2457
@trevor-scheer
Update to apollo-graphql@0.9.5
3f30be7
@trevor-scheer
Update test and fixtures
f4962ea
@trevor-scheer
Update fn names and comments
c201571
@trevor-scheer
Move ContactDirective into subgraph only directive groups
a90b467
@trevor-scheer
Update ContactDirective definition to match docs
551c689
@trevor-scheer
Rename / rebucket subgraph directives to be more obvious about
009f633 
how they're used and how they end up in the schema.

Break dependency of supergraph printing from list exported by
subgraph package since this dependency doesn't really make sense.
The supergraph should know internally what it supports and how it
should print.
@trevor-scheer
Naming tweak (and comment updates)
78d6413
@trevor-scheer trevor-scheer merged commit 479a7a9 into apollographql:version-0.x Nov 20, 2021
@trevor-scheer trevor-scheer removed their request for review November 20, 2021 01:08
trevor-scheer added a commit that referenced this pull request Nov 22, 2021
@trevor-scheer
Adjust changelog entries for #1096
789228d
@iMobs iMobs mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer left review comments

@glasser glasser glasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lennyburdette @glasser @trevor-scheer