fix(subgraph): Subgraph printer to propagate @tag usages #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag directive usages and definitions weren't being properly printed by printSubgraphSchema. This was a copy/paste error which tried to leverage how printSupergraphSchema printed @tag usages, but it really just didn't make sense in the context of a subgraph. We have 2 very different approaches to reading and printing metadata. The tests were also incorrect, so fixing the bug triggered a snapshot update which now reflects the printer is functioning as expected.
martijnwalraven
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag directive usages and definitions weren't being properly printed by
printSubgraphSchema. This was a copy/paste error which tried to leverage howprintSupergraphSchemaprinted@tagusages, but it really just didn't make sense in the context of a subgraph. We have 2 very different approaches to reading and printing metadata. The tests were also incorrect, so fixing the bug triggered a snapshot update which now reflects the printer is functioning as expected.Fixes #1069