uniqueTypeNamesWithFields points to return types

apollographql · May 5, 2021 · ae3e2ca · ae3e2ca
1 parent 8b638e8
commit ae3e2ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/federation-js/src/composition/validate/sdl/__tests__/uniqueTypeNamesWithFields.test.ts b/federation-js/src/composition/validate/sdl/__tests__/uniqueTypeNamesWithFields.test.ts
@@ -111,11 +111,11 @@ describe('UniqueTypeNamesWithFields', () => {
             "code": "VALUE_TYPE_FIELD_TYPE_MISMATCH",
             "locations": Array [
               Object {
-                "column": 3,
+                "column": 8,
                 "line": 3,
               },
               Object {
-                "column": 3,
+                "column": 8,
                 "line": 3,
               },
             ],
@@ -125,11 +125,11 @@ describe('UniqueTypeNamesWithFields', () => {
             "code": "VALUE_TYPE_FIELD_TYPE_MISMATCH",
             "locations": Array [
               Object {
-                "column": 3,
+                "column": 13,
                 "line": 5,
               },
               Object {
-                "column": 3,
+                "column": 13,
                 "line": 5,
               },
             ],

diff --git a/federation-js/src/composition/validate/sdl/uniqueTypeNamesWithFields.ts b/federation-js/src/composition/validate/sdl/uniqueTypeNamesWithFields.ts
@@ -118,7 +118,7 @@ export function UniqueTypeNamesWithFields(
                 } respectively. In order to define \`${typeName}\` in multiple places, the fields and their types must be identical.`,
                 // TODO (Issue #705): when we can associate locations to service names
                 // add locations for each service where this field was defined
-                fieldNode && duplicateFieldNode ? [fieldNode, duplicateFieldNode] : undefined,
+                fieldNode && duplicateFieldNode ? [fieldNode.type, duplicateFieldNode.type] : undefined,
               ),
             );
             return true;