Skip to content

Commit

Permalink
fix: Dependency issues introduced by changes to underlying tooling pa…
Browse files Browse the repository at this point in the history
…ckages (#699)

Remove lingering references to core-js.

Update `apollo-graphql` to `latest`, which includes a dependency fix for a missing
package `sha.js` which was previously required transitively.

Fixes #692.
Fixes #693.
  • Loading branch information
glasser authored Apr 26, 2021
1 parent 7eefe8d commit 6bffe42
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 11 deletions.
2 changes: 1 addition & 1 deletion federation-integration-testsuite-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"node": ">=12"
},
"dependencies": {
"apollo-graphql": "^0.9.0",
"apollo-graphql": "^0.9.2",
"graphql-tag": "^2.10.4"
}
}
2 changes: 1 addition & 1 deletion federation-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
- _Nothing yet! Stay tuned!_
- Remove lingering `core-js` polyfill imports, they're no longer needed (since `@apollo/gateway@0.15.0` dropped support for <= Node.js v10) and their presence is problematic since `core-js` isn't defined as a dependency within the package. Update `apollo-graphql` dependency which resolves a missing dependency (`sha.js`) within that package. [PR #699](https://github.com/apollographql/federation/pull/699)

## v0.23.1

Expand Down
2 changes: 1 addition & 1 deletion federation-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"access": "public"
},
"dependencies": {
"apollo-graphql": "^0.9.0",
"apollo-graphql": "^0.9.2",
"lodash.xorby": "^4.7.0"
},
"peerDependencies": {
Expand Down
3 changes: 0 additions & 3 deletions federation-js/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
import "core-js/features/array/flat";
import "core-js/features/array/flat-map";

export * from './composition';
export * from './service';
2 changes: 1 addition & 1 deletion gateway-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
- _Nothing yet! Stay tuned!_
- Update `apollo-graphql` dependency which resolves a missing dependency (`sha.js`) within that package. [PR #699](https://github.com/apollographql/federation/pull/699)

## v0.26.2

Expand Down
2 changes: 1 addition & 1 deletion gateway-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@apollo/federation": "file:../federation-js",
"@apollo/query-planner": "file:../query-planner-js",
"@types/node-fetch": "2.5.10",
"apollo-graphql": "^0.9.0",
"apollo-graphql": "^0.9.2",
"apollo-reporting-protobuf": "^0.6.0",
"apollo-server-caching": "^0.6.0",
"apollo-server-core": "^2.23.0",
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6bffe42

Please sign in to comment.