Skip to content

Commit

Permalink
Add production dependency on @types/node-fetch. (apollographql/apol…
Browse files Browse the repository at this point in the history
…lo-server#3546)

* Add production dependency on `@types/node-fetch`.

As the `HeadersInit` is exported and used in the exported [`GatewayConfig`]
type via [`RemoteGatewayConfig`] - which is emitted to `@apollo/gateway`'s
`dist/index.d.ts` declaration, the `node-fetch` types need to be available
by those who install the package.

[`GatewayConfig`]: https://github.com/apollographql/apollo-server/blob/73cdf0d533908894282debdb6dc5444186af27a6/packages/apollo-gateway/src/index.ts#L74-L77
[`RemoteGatewayConfig`]: https://github.com/apollographql/apollo-server/blob/73cdf0d533908894282debdb6dc5444186af27a6/packages/apollo-gateway/src/index.ts#L62

Fixes: apollographql/apollo-server#3471

* Add CHANGELOG.md for apollographql/apollo-server#3546.

Apollo-Orig-Commit-AS: apollographql/apollo-server@c63786b
  • Loading branch information
abernix authored Nov 27, 2019
1 parent ab5a3a4 commit 3f16c7a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gateway-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
"dependencies": {
"@apollo/federation": "file:../apollo-federation",
"@types/node-fetch": "2.5.4",
"apollo-engine-reporting-protobuf": "file:../apollo-engine-reporting-protobuf",
"apollo-env": "^0.6.0",
"apollo-graphql": "^0.3.4",
Expand Down

0 comments on commit 3f16c7a

Please sign in to comment.