Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo: remove unused schemaDiff #967

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Conversation

evans
Copy link
Contributor

@evans evans commented Feb 5, 2019

This removes unused and undocumented code that is a holdover from
apollo@1 and tech debt. Since apollo is a commandline tool, this code
should not be used outside of Apollo's internal Platform tools, so I
suggest that the code be removed without a major version bump

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@evans evans force-pushed the evans/remove-deprecated branch 2 times, most recently from 7d5ac71 to 6566ccc Compare February 5, 2019 01:10
evans added 3 commits February 4, 2019 17:12
This removes unused and undocumented code that is a holdover from
apollo@1 and tech debt.  Since `apollo` is a commandline tool, this code
should not be used outside of Apollo's internal Platform tools, so I
suggest that the code be removed without a major version bump
@evans evans force-pushed the evans/remove-deprecated branch from 6566ccc to 312e006 Compare February 5, 2019 01:12
@trevor-scheer
Copy link
Member

Thanks for the cleanup 🎉

@trevor-scheer trevor-scheer merged commit 92ee40d into master Feb 5, 2019
@trevor-scheer trevor-scheer deleted the evans/remove-deprecated branch February 5, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants